Conversation
|
Regarding If you default to grep, a good chunk of people won't bother to change it and will have a worse experience out of the box. |
|
Good idea, added! |
| end | ||
|
|
||
|
|
||
| if vim.fn.executable(command) ~= 1 then |
There was a problem hiding this comment.
Probably worth just keeping this just in case
There was a problem hiding this comment.
Yes, this basically cleanly saveguards against not having grep installed. I know grep is on every Linux system, I don't know about macOS, and I'm sure Windows doesn't have it.
There was a problem hiding this comment.
But this check on line 27 and on line 21 are the same?
There was a problem hiding this comment.
I believe it's to check for rg then grep
|
This is looking good. I'll need to test this before I merge this in but do you know if this works with things like ignorecase? |
|
I completely forgot about that, I will have to conditionally add some flags. Shouldn't be difficult, I'll update later today. |
|
Any update on this one? |
|
@CallumHoward Refactor of the main codebase is in the works, I'll try to add independent search based off this when I have the chance |
|
I'm excited for this refactor! Thanks for your hard work |
4 participants
Closes #5.
I'll commit some more documentation later (i.e. on replacing
rgwith a different tool). We may consider replacingrgby default withgrep, althoughrgis faster everybody has grep installed.